Things that need blacklisting

Copy from the old forums:

I think the following stuff was mistakenly whitelisted:

Finishers:Realm Portal Spike Finisher - id 72 - maybe expansion content?

• A heavy headgear with no name – 2036
• Heavy Scale Helm, gloves, legs, boots are whitelisted twice – 1579, 1542, 1499, 1534
• Mistwrap set is whitelisted twice – 5948, 5936, 5921, 5918, 5910, 5909
• heavy hands with no name – 2118
• Medium shoulders with no name – 681
• Sword with no name – 3355
• Various items in the LargeBundle, SmallBundle, Toy, ToyTwoHanded categories – none of this can be unlocked to my knowledge – 2434, 2605, 2661, 2743, 2775, 2788, 3689 – 2809, 2829, 2835, 2851, 2913, 2930, 3046, 3080 – 3185, 3186, 3187, 3188, 3190, 3192 – 3239, 3241, 3242, 3244, 3245
• Gathering type items? not skins – 2384, 2385, 2387, 2388, 2391, 2391, 2392, 2393, 2394, 2395, 2396, 2398, 2399, 5655, 5656, 5657, 5658, 5749, 5884, 5906, 5951, 6055, 6063, 6075, 6741, 6962, 7034, 7068,
• Hammer with no name – 3272
• Hammers called Ironfist (dummy item?) and Mistbreaker (not ingame) – 4879, 5898
• Shortbow with no name – 5353
• Shadow Assassin Short Bow (does not exist, same skin as Merciless Short Bow) – 6072
• Rifle with no name – 2445
• Staff with no name and strange icon – 3265
• Backpack Straps (not an unlockable skin) – 2327
• two backpacks with no names – 2329, 2339

It's hard to tell why these items made it into the API -- they might have been acquired by players via some means and might be returned via one of the inventory endpoints. To maintain backwards compatibility, I've been leaning on the side of "don't remove them".

Ironfist, 4879, is currently used by the Bloodbound Hammer.

Backpack Straps, 2327, will be continually unlocked, as it is a skin for current items.

Unnamed backpacks, 2329 and 2339 also have current items which use these skins.

Probably selfish opinion: I would prefer to see this stuff blacklisted also - that only appeared by errors (support or ingame). They ruin the completion view on gw2efficiency wardrobe. Since I have almost everything unlocked these pop up every time when I filter for "not unlocked" stuff.

@Malediktus.9250 said:Probably selfish opinion: I would prefer to see this stuff blacklisted also - that only appeared by errors (support or ingame). They ruin the completion view on gw2efficiency wardrobe. Since I have almost everything unlocked these pop up every time when I filter for "not unlocked" stuff.

I have a different opinion. Like for items there are some skins that are not commonly used in game, but if an app filter all those skins and shows only the one flagged with ShowInWardrobe I don't see any problem.I asked about Mistward skins some months ago and indeed ShowInWardrobe flag is the solution. If you try to check almost all the ids mentioned above you will see that they don't have that flag except id 6072, so they shouldn't be used.

But that sounds like something the app and website creators would have to consider. Not sure if they would consider it worth the effort for less than 100 out of thousands of ids.I think it is always better to fix problems at their root instead of making workarounds.

@Greener.6204 said:

• Ironfist, 4879, is currently used by the Bloodbound Hammer.
• Backpack Straps, 2327, will be continually unlocked, as it is a skin for current items.
• Unnamed backpacks, 2329 and 2339 also have current items which use these skins.

Those items do not actually unlock them as skins. If you look at those items ingame, for example [&AgEXLgEA] for Bloodbound Hammer, then you see that they do not have any skin for unlocking. For the backpacks I can even confirm it from first hand since I had plenty of those items listed on the wiki, and not unlocked the skin ids.If something is not actually unlockable it should not appear in a skin/wardrobe API. Putting the burden to program exceptions and additional rules for workarounds on the application creators is not acceptable imo.

I'm confused. Looking at the API for item 77335 (bloodbound hammer), it lists its skin as 4879, so how is it that "it does not have any skin for unlocking?"

(I can agree that there are too many exceptions in the system -- it must be a nightmare for Lawton Campbell to manage; that can't be good for the game, for the dev, nor for us as a community.)

@"Lawton Campbell.8517" said:It's hard to tell why these items made it into the API -- they might have been acquired by players via some means and might be returned via one of the inventory endpoints. To maintain backwards compatibility, I've been leaning on the side of "don't remove them".

I tend to agree. While we'd all prefer that these errors never occur, that will never be a guarantee and API devs will have to deal with pruning their databases one way or the other. In the long run I think it makes more sense for apps to have more robust logic that filters bad entries rather than having to chase down individual errors every time they happen. And in principle I don't think that information should ever be removed once it's been released. This will lead to a situation where some databases have the info and others don't, and make it ambiguous as to whether an error originated in the API or in the downstream database.

@"Illconceived Was Na.9781" said:I'm confused. Looking at the API for item 77335 (bloodbound hammer), it lists its skin as 4879, so how is it that "it does not have any skin for unlocking?"

(I can agree that there are too many exceptions in the system -- it must be a nightmare for Lawton Campbell to manage; that can't be good for the game, for the dev, nor for us as a community.)

Items can have skins without making them unlockable.It is probably related to wether the skin has "ShowInWardrobe" flag. If the skin id is missing that flag the item will not unlock a skin. It is easy to check ingame. If the tooltip of a piece of equipment lists no skin, it will not unlock a skin.

Theory how this stuff made it to the API: someone got the item and the skin is automatically whitelisted in process without checking if it has the ShowinWardrobe flag which determines if the item actually has an unlockable skin.