I lowkey love it. Great way to make gold (though Ambergris has dropped like 33% in sale price since June), relaxing but not overly boring, and a great way to kill some down-time in between other activities like map metas and instanced runs. As an avid podcast listener, this is the game's best "do while listening to audio" activity by a country mile.
Now, no system is perfect, and Anet could certainly stand to improve fishing mechanics and implement some QoL improvements for them. Also, I haven't really tried for the fishing achievements yet, and I've heard the Dusk/Dawn fish are a pain to get.
I really like the tackle box suggestion. Additionally, the skiff sorely needs to gain a skill to either kill pesky mobs, or enter stealth to avoid combat completely. And I would love it if the party stacking buff lasts longer after disembarking, and/or persists through a map change.