Forum bug: Javascript not working in IE

[Khisanth.2948]

hmm too lazy to dig further at the moment but we can seehttps://en-forum.guildwars2.com/js/flyouts.js?v=2.8%2B2019.003.5c80426fvshttps://forums.elderscrollsonline.com/js/flyouts.js?v=2.8.5c8045fe

so the version numbers are not the same, if you check the page info the GW2 forum's was last modified March 6, 2019 while the ESO forum was last modified Feburary 14, 2019

~~https://www.diffchecker.com/2qT8LItM looking at the changes the culprit might just ~~

Uh ... it seems like error is due to one annoying comma in

var $handle=$(this).find(".FlyoutButton, .Button-Options, .Handle, .editor-action:not(.editor-action-separator)",);

The very last one in ",);"

That was also the thing that stood out when I first looked at it earlier.

... and looking at the unminified version at https://en-forum.guildwars2.com/js/flyouts.js?v=2.8+2019.003.5c80426f (note + vs percent 2 b) it looks like my earlier accusation towards the minifier was wrong. That comma is in the original.

[Bloodstealer.5978]

@Khisanth.2948 said:The message is a bit misleading but what is actually happening is that the the Javascript code minifier is probably using new JS syntax that IE doesn't support.

The result is that IE can't parse the JS files and the features that require JS doesn't work.

This is not the first time this has happened with the forums.. button functionality is screwed up like before and it's not just limited to IE as I am getting the errors in Edge as well on occasion and others have said they get issues with chrome. Firefox seems to work ok though.Can't edit posts or even log out of the forums anymore :)Gaile used to jump all over Vanilla to sort this rubbish out.. guess this is the sign of the times.

[Danikat.8537]

The joys of people leaving without a hand-over period, you suddenly find out just how many things only that one person knew how to do!

(Or even with a hand-over period if you later discover the notes they wrote include helpful things like "If this doesn't work call Nick - he will sort it" with absolutely no hint of who Nick is, what his phone number is or how to find out.)

[Danikat.8537]

@"Khisanth.2948" said:hmm too lazy to dig further at the moment but we can seehttps://en-forum.guildwars2.com/js/flyouts.js?v=2.8%2B2019.003.5c80426fvshttps://forums.elderscrollsonline.com/js/flyouts.js?v=2.8.5c8045fe

so the version numbers are not the same, if you check the page info the GW2 forum's was last modified March 6, 2019 while the ESO forum was last modified Feburary 14, 2019

~~https://www.diffchecker.com/2qT8LItM looking at the changes the culprit might just ~~

Uh ... it seems like error is due to one annoying comma in

var $handle=$(this).find(".FlyoutButton, .Button-Options, .Handle, .editor-action:not(.editor-action-separator)",);

The very last one in ",);"

That was also the thing that stood out when I first looked at it earlier.

... and looking at the unminified version at

https://en-forum.guildwars2.com/js/flyouts.js?v=2.8+2019.003.5c80426f

(note + vs percent 2 b) it looks like my earlier accusation towards the minifier was wrong. That comma is in the original.

Thanks for taking the time to investigate, and for the explanation. Even if we can't fix the problem it's nice to know what's going on at least.

[Leablo.2651]

Trailing commas are not a syntax violation in JavaScript. In particular, such commas in function calls have been legal since ES8. The issue remains with the choice of browser.

[Bloodstealer.5978]

@Leablo.2651 said:Trailing commas are not a syntax violation in JavaScript. In particular, such commas in function calls have been legal since ES8. The issue remains with the choice of browser.

Except its happening on a variety of browsers not just IE.. so that kinda pushes that theory out the window.. so far Firefox users have reported issues, IE users, Edge users only one I am not sure of is chrome as yet.

[Bloodstealer.5978]

As said previously.. this is the same issue the forums had after Vanilla had been playing around and which Gaile got them to sort out quicksmart.. but that doesn't seem likely to happen now, it's not even warranted an acknowledgment of the issue from ANET thus far.

[Inculpatus cedo.9234]

I use Firefox with no issue.Just tried Chrome; again, no issue.I'm using Win10. Must be something other than the browser.

[Poormany.4507]

I'm using an older version of Firefox and it has the same issues issues, so I think it only affects older browsers and versions. Newest version of Chrome works fine for me. All on Windows 10.

[MDove.2391]

Coming in on Firefox, just fine.Guess will need to Bookmark the Forums, instead of coming in on the Client...

[Danikat.8537]

This seems to have been fixed, at least for me. Notifications and the reaction button are working again in all my browsers. :)

[Bloodstealer.5978]

@Danikat.8537 said:This seems to have been fixed, at least for me. Notifications and the reaction button are working again in all my browsers. :)

Yip appears to have been resolved again..

[Leablo.2651]

@Bloodstealer.5978 said:

@"Leablo.2651" said:Trailing commas are not a syntax violation in JavaScript. In particular, such commas in function calls have been legal since ES8. The issue remains with the choice of browser.

Except its happening on a variety of browsers not just IE.. so that kinda pushes that theory out the window.. so far Firefox users have reported issues, IE users, Edge users only one I am not sure of is chrome as yet.

If by "variety" you mean IE, the other Microsoft browser, and very old versions of other browsers, sure. I'm relatively slow to update myself, I've been on Firefox ESR and haven't had a single problem with these forums and you can see in this thread that people on other browsers reported no issues. It is a choice to use outdated browsers regardless of their branding. There is no "fix" for them, there are only workarounds, and this kind of thing will only continue to happen with increasing frequency across all websites as older browsers continue to fall off the radar.

[Bloodstealer.5978]

@Leablo.2651 said:

@Bloodstealer.5978 said:

@Leablo.2651 said:Trailing commas are not a syntax violation in JavaScript. In particular, such commas in function calls have been legal since ES8. The issue remains with the choice of browser.

Except its happening on a variety of browsers not just IE.. so that kinda pushes that theory out the window.. so far Firefox users have reported issues, IE users, Edge users only one I am not sure of is chrome as yet.

If by "variety" you mean IE, the other Microsoft browser, and very old versions of other browsers, sure. I'm relatively slow to update myself, I've been on Firefox ESR and haven't had a single problem with these forums and you can see in this thread that people on other browsers reported no issues. It is a choice to use outdated browsers regardless of their branding. There is no "fix" for them, there are only workarounds, and this kind of thing will only continue to happen with increasing frequency across all websites as older browsers continue to fall off the radar.

Not about being slow to upgrade or update, it's about preference.I dislike Firefox and Chrome whilst Edge makes the forums look ugly and read bad to me. IE is a choice I take for the moment. .This is not some new issue, this had happened previously and may of been Vanilla tweaking that pushed issues not browser choice.Sure at some point browsers may become unsupported like IE.. but then ANET/Vanilla need to make it clear their forums will no longer function unless browser choice is updated.. until then it may be that they choose to place "workarounds" … btw it's once again all fine and dandy.

[Leablo.2651]

@Bloodstealer.5978 said:IE is a choice I takeAgreed.